From bc154f8b6b7999a39f15d4a8746ffd343a68e376 Mon Sep 17 00:00:00 2001
From: dm1sh <me@dmitriy.icu>
Date: Thu, 20 Jul 2023 00:55:12 +0300
Subject: [PATCH] Fixed useFetch and useUser typing

---
 front/src/hooks/api/useUser.ts        |  5 +++--
 front/src/hooks/useFetch.ts           | 27 +++++++++------------------
 front/src/hooks/useStoryDimensions.ts |  6 ++++--
 3 files changed, 16 insertions(+), 22 deletions(-)

diff --git a/front/src/hooks/api/useUser.ts b/front/src/hooks/api/useUser.ts
index 5531490..ca22c1a 100644
--- a/front/src/hooks/api/useUser.ts
+++ b/front/src/hooks/api/useUser.ts
@@ -1,8 +1,8 @@
 import { initialUser } from '../../api/user'
 import { User } from '../../api/user/types'
-import { UseFetchErrored, UseFetchSucced } from '../useFetch'
+import { UseFetchReturn } from '../useFetch'
 
-const useUser = (): UseFetchSucced<User> | UseFetchErrored => (
+const useUser = (): UseFetchReturn<User> => (
     // useFetch(
     //     composeUserUrl(getToken()),
     //     'GET',
@@ -16,6 +16,7 @@ const useUser = (): UseFetchSucced<User> | UseFetchErrored => (
         data: initialUser,
         loading: false,
         error: null,
+        setData: () => {0}
     }
 )
 
diff --git a/front/src/hooks/useFetch.ts b/front/src/hooks/useFetch.ts
index b401601..fdeda57 100644
--- a/front/src/hooks/useFetch.ts
+++ b/front/src/hooks/useFetch.ts
@@ -3,40 +3,31 @@ import { useEffect, useState } from 'react'
 import { SetState } from '../utils/types'
 import useSend from './useSend'
 
-type UseFetchShared = {
+type UseFetchShared<T> = {
     loading: boolean,
     abort?: () => void,
+    setData: SetState<T | undefined>
 }
 
 type UseFetchSucced<T> = {
     error: null,
     data: T,
-} & UseFetchShared
+} & UseFetchShared<T>
 
-type UseFetchErrored = {
+type UseFetchErrored<T> = {
     error: string,
     data: undefined
-} & UseFetchShared
+} & UseFetchShared<T>
 
-const gotError = <T>(res: UseFetchErrored | UseFetchSucced<T>): res is UseFetchErrored => (
+const gotError = <T>(res: UseFetchErrored<T> | UseFetchSucced<T>): res is UseFetchErrored<T> => (
     typeof res.error === 'string'
 )
 
-const fallbackError = <T>(res: UseFetchSucced<T> | UseFetchErrored) => (
+const fallbackError = <T>(res: UseFetchSucced<T> | UseFetchErrored<T>) => (
     gotError(res) ? res.error : res.data
 )
 
-type UseFetchReturn<T> = ({
-    error: null,
-    data: T
-} | {
-    error: string,
-    data: undefined
-}) & {
-    loading: boolean,
-    setData: SetState<T | undefined>
-    abort?: (() => void)
-}
+type UseFetchReturn<T> = UseFetchSucced<T> | UseFetchErrored<T>
 
 function useFetch<R, T>(
     url: string,
@@ -70,7 +61,7 @@ function useFetch<R, T>(
     }
 }
 
-export type { UseFetchErrored, UseFetchSucced }
+export type { UseFetchReturn }
 
 export default useFetch
 
diff --git a/front/src/hooks/useStoryDimensions.ts b/front/src/hooks/useStoryDimensions.ts
index 7d69655..c0e2770 100644
--- a/front/src/hooks/useStoryDimensions.ts
+++ b/front/src/hooks/useStoryDimensions.ts
@@ -14,12 +14,14 @@ function useStoryDimensions(maxRatio = 16 / 9) {
         function handleResize() {
             setWindowDimensions(getWindowDimensions());
         }
-    
+
         window.addEventListener('resize', handleResize);
         return () => window.removeEventListener('resize', handleResize);
     }, []);
 
-    const height = windowDimensions.height - 56
+    const bottomBarHeight = 56
+
+    const height = windowDimensions.height - bottomBarHeight
 
     const ratio = Math.max(maxRatio, height / windowDimensions.width)