From 26f2fb01906ad74357e98c2fd281d368adf14c03 Mon Sep 17 00:00:00 2001 From: Jonathan Lestrelin Date: Mon, 25 Sep 2017 19:34:09 +0200 Subject: [PATCH] Fix delayed notification problem due to blocking subprocess call. --- gnome-pass-search-provider.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/gnome-pass-search-provider.py b/gnome-pass-search-provider.py index 9a212a0..651ba69 100755 --- a/gnome-pass-search-provider.py +++ b/gnome-pass-search-provider.py @@ -126,13 +126,10 @@ class SearchPassService(dbus.service.Object): self.notify('Failed to copy password', body=error, error=True) def send_password_to_native_clipboard(self, name): - pass_cmd = subprocess.run( - ['pass', 'show', '-c', name], - stderr=subprocess.PIPE - ) - error = re.sub(b'\n$', b'', pass_cmd.stderr) + pass_cmd = subprocess.run(['pass', 'show', '-c', name]) + if pass_cmd.returncode: - self.notify('Failed to copy password', body=error, error=True) + self.notify('Failed to copy password!', error=True) else: self.notify('Password {} copied to clipboard.'.format(name))