From 67abd14bb10a8425dfc0a596cb2ced7e9396df2d Mon Sep 17 00:00:00 2001 From: Tommaso Berlose Date: Wed, 5 May 2021 12:11:51 +0200 Subject: [PATCH] Bugfixes --- .../anotherwidget/helpers/ImageHelper.kt | 2 +- .../helpers/MediaPlayerHelper.kt | 2 + .../receivers/NotificationListener.kt | 1 + .../ui/fragments/MainFragment.kt | 2 +- .../ui/widgets/LeftAlignedWidget.kt | 2 +- .../ui/widgets/StandardWidget.kt | 3 +- .../res/layout/activity_media_info_format.xml | 5 +- .../main/res/layout/left_aligned_widget.xml | 11 +- .../res/layout/left_aligned_widget_sans.xml | 6 +- .../main/res/layout/right_aligned_widget.xml | 280 ------------------ .../res/layout/right_aligned_widget_sans.xml | 173 ----------- 11 files changed, 14 insertions(+), 473 deletions(-) delete mode 100644 app/src/main/res/layout/right_aligned_widget.xml delete mode 100644 app/src/main/res/layout/right_aligned_widget_sans.xml diff --git a/app/src/main/java/com/tommasoberlose/anotherwidget/helpers/ImageHelper.kt b/app/src/main/java/com/tommasoberlose/anotherwidget/helpers/ImageHelper.kt index 257115d..d852137 100644 --- a/app/src/main/java/com/tommasoberlose/anotherwidget/helpers/ImageHelper.kt +++ b/app/src/main/java/com/tommasoberlose/anotherwidget/helpers/ImageHelper.kt @@ -20,7 +20,7 @@ object ImageHelper { else -> 0f * factor }, resources.displayMetrics) - if (originalView.drawable != null) { + if (originalView.drawable != null && originalView.drawable.intrinsicWidth > 0 && originalView.drawable.intrinsicHeight > 0) { val btm = originalView.drawable.toBitmap().copy(Bitmap.Config.ARGB_8888, true) val comb = Bitmap.createBitmap(btm) val shadowBitmap = generateShadowBitmap(context, cElevation, btm, factor) diff --git a/app/src/main/java/com/tommasoberlose/anotherwidget/helpers/MediaPlayerHelper.kt b/app/src/main/java/com/tommasoberlose/anotherwidget/helpers/MediaPlayerHelper.kt index cd51492..5d20eac 100644 --- a/app/src/main/java/com/tommasoberlose/anotherwidget/helpers/MediaPlayerHelper.kt +++ b/app/src/main/java/com/tommasoberlose/anotherwidget/helpers/MediaPlayerHelper.kt @@ -33,12 +33,14 @@ object MediaPlayerHelper { DEFAULT_MEDIA_INFO_FORMAT.replace(MEDIA_INFO_TITLE, title) .replace(MEDIA_INFO_ARTIST, artist) .replace(MEDIA_INFO_ALBUM, album) + .replace("\\n", System.getProperty("line.separator") ?: " ") } } else -> { format.replace(MEDIA_INFO_TITLE, title) .replace(MEDIA_INFO_ARTIST, artist) .replace(MEDIA_INFO_ALBUM, album) + .replace("\\n", System.getProperty("line.separator") ?: " ") } } } diff --git a/app/src/main/java/com/tommasoberlose/anotherwidget/receivers/NotificationListener.kt b/app/src/main/java/com/tommasoberlose/anotherwidget/receivers/NotificationListener.kt index e86d2ba..6a6bcf1 100644 --- a/app/src/main/java/com/tommasoberlose/anotherwidget/receivers/NotificationListener.kt +++ b/app/src/main/java/com/tommasoberlose/anotherwidget/receivers/NotificationListener.kt @@ -9,6 +9,7 @@ import android.service.notification.NotificationListenerService import android.service.notification.StatusBarNotification import android.util.Log import android.widget.Toast +import com.google.gson.Gson import com.tommasoberlose.anotherwidget.global.Actions import com.tommasoberlose.anotherwidget.global.Constants import com.tommasoberlose.anotherwidget.global.Preferences diff --git a/app/src/main/java/com/tommasoberlose/anotherwidget/ui/fragments/MainFragment.kt b/app/src/main/java/com/tommasoberlose/anotherwidget/ui/fragments/MainFragment.kt index c890ea7..5406549 100644 --- a/app/src/main/java/com/tommasoberlose/anotherwidget/ui/fragments/MainFragment.kt +++ b/app/src/main/java/com/tommasoberlose/anotherwidget/ui/fragments/MainFragment.kt @@ -45,7 +45,7 @@ class MainFragment : Fragment() { companion object { fun newInstance() = MainFragment() private val PREVIEW_BASE_HEIGHT: Int - get() = if (Preferences.widgetAlign == Constants.WidgetAlign.CENTER.rawValue) 120 else 200 + get() = if (Preferences.widgetAlign == Constants.WidgetAlign.CENTER.rawValue) 120 else 180 } private lateinit var viewModel: MainViewModel diff --git a/app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/LeftAlignedWidget.kt b/app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/LeftAlignedWidget.kt index 5040072..6d89ea0 100644 --- a/app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/LeftAlignedWidget.kt +++ b/app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/LeftAlignedWidget.kt @@ -238,7 +238,7 @@ class LeftAlignedWidget(val context: Context) { views.setViewVisibility(R.id.sub_line_top_margin_small_sans, View.GONE) views.setViewVisibility(R.id.sub_line_top_margin_medium_sans, View.GONE) views.setViewVisibility(R.id.sub_line_top_margin_large_sans, View.GONE) - } else if (GlanceProviderHelper.showGlanceProviders(context) && bindingView.calendarLayout.isVisible) { + } else if (GlanceProviderHelper.showGlanceProviders(context)) { var showSomething = false loop@ for (provider: Constants.GlanceProviderId in GlanceProviderHelper.getGlanceProviders(context)) { when (provider) { diff --git a/app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/StandardWidget.kt b/app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/StandardWidget.kt index f9d3b7d..f4b2b79 100644 --- a/app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/StandardWidget.kt +++ b/app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/StandardWidget.kt @@ -8,6 +8,7 @@ import android.content.Intent import android.graphics.Color import android.graphics.Typeface import android.text.format.DateUtils +import android.util.Log import android.util.TypedValue import android.view.LayoutInflater import android.view.View @@ -260,7 +261,7 @@ class StandardWidget(val context: Context) { views.setViewVisibility(R.id.first_line_rect, View.GONE) - } else if (GlanceProviderHelper.showGlanceProviders(context) && bindingView.calendarLayout.isVisible) { + } else if (GlanceProviderHelper.showGlanceProviders(context)) { var showSomething = false loop@ for (provider: Constants.GlanceProviderId in GlanceProviderHelper.getGlanceProviders(context)) { when (provider) { diff --git a/app/src/main/res/layout/activity_media_info_format.xml b/app/src/main/res/layout/activity_media_info_format.xml index 5138a46..25c9526 100644 --- a/app/src/main/res/layout/activity_media_info_format.xml +++ b/app/src/main/res/layout/activity_media_info_format.xml @@ -110,10 +110,7 @@ app:textAllCaps="false" android:gravity="center_vertical|start" android:textAlignment="viewStart" - android:maxLines="1" - android:lines="1" - android:singleLine="true" - android:ellipsize="end" + android:maxLines="2" android:layout_marginLeft="32dp" android:layout_marginRight="32dp" /> diff --git a/app/src/main/res/layout/left_aligned_widget.xml b/app/src/main/res/layout/left_aligned_widget.xml index 276fb0d..89ee934 100644 --- a/app/src/main/res/layout/left_aligned_widget.xml +++ b/app/src/main/res/layout/left_aligned_widget.xml @@ -1,7 +1,6 @@ + android:orientation="vertical"> @@ -150,6 +147,7 @@ android:layout_height="wrap_content" android:cropToPadding="false" android:clipChildren="false" + android:layout_marginTop="2dp" android:layout_marginEnd="4dp"> diff --git a/app/src/main/res/layout/left_aligned_widget_sans.xml b/app/src/main/res/layout/left_aligned_widget_sans.xml index e2f2311..131c28e 100644 --- a/app/src/main/res/layout/left_aligned_widget_sans.xml +++ b/app/src/main/res/layout/left_aligned_widget_sans.xml @@ -12,7 +12,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:orientation="vertical" - android:gravity="center_vertical" android:paddingLeft="8dp" android:paddingRight="8dp" android:id="@+id/main_layout" @@ -75,9 +74,7 @@ android:layout_height="wrap_content"> + android:layout_height="wrap_content"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/app/src/main/res/layout/right_aligned_widget_sans.xml b/app/src/main/res/layout/right_aligned_widget_sans.xml deleted file mode 100644 index 85ce6f5..0000000 --- a/app/src/main/res/layout/right_aligned_widget_sans.xml +++ /dev/null @@ -1,173 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file